Conversation
This test assumes the task callbacks that log the task records will run in the same order the tasks were submitted. This is not the case, so it is not guarenteed the record for the second task will be second in the records list.
Forbidding extra options in the engine plugin configs (executor, filter, and transformer) meant that trying to override the plugin type defined in a config file from a CLI argument would raise an "extra options forbidden" error by the pydantic validators because of the options for the not used plugin variant in the config. This change should support that use case. Note that the run Config and AppConfig still forbid extra options as a sanity check, and those don't have the same issue of wanting to frequently switch the plugin type.
gpauloski
added
the
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Automatically resolve
pathlib.Pathtypes inAppConfigso that absolute paths are created on initialization. This removes the need for the custom field validators to avoid unexpected relative path failures whentaps.runchanges the CWD to therun_dir.Fixes
Type of Change
Testing
Added tests, and testing with the
fedlearnapp.Pull Request Checklist
Please confirm the PR meets the following requirements.
pre-commit(e.g., ruff, mypy, etc.).