Skip to content

Fix exception logging in task callback#81

Merged
gpauloski merged 1 commit intomainfrom
task-exception-logging
Jun 28, 2024
Merged

Fix exception logging in task callback#81
gpauloski merged 1 commit intomainfrom
task-exception-logging

Conversation

@gpauloski
Copy link
Copy Markdown
Contributor

Description

Previously, if a task raised an exception, the task callback handler would also raise the exception instead of just recording the exception. This is fixed now, and the execution info in task records is more verbose.

Fixes N/A

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (internal implementation changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (no changes to the code)
  • CI change (changes to CI workflows, packages, templates, etc.)
  • Version changes (changes to the package or dependency versions)

Testing

Added a unit test.

Pull Request Checklist

Please confirm the PR meets the following requirements.

  • Relevant tags are added (breaking, bug, dependencies, documentation, enhancement, refactor).
  • Code changes pass pre-commit (e.g., ruff, mypy, etc.).
  • Tests have been added to show the fix is effective or that the new feature works.
  • New and existing unit tests pass locally with the changes.
  • Docs have been updated and reviewed if relevant.

@gpauloski gpauloski added the bug Something isn't working label Jun 28, 2024
@gpauloski gpauloski merged commit b495b70 into main Jun 28, 2024
@gpauloski gpauloski deleted the task-exception-logging branch June 28, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant