Merged
Conversation
gpauloski
added
the
enhancement
gpauloski
reviewed
Jun 27, 2024
Contributor
gpauloski
left a comment
gpauloski
left a comment
There was a problem hiding this comment.
Thanks for the PR, @ClaudiaCumberbatch!
I've only taken a high-level look so far. My big question is how best to handle the configuration options for the "true workflow." I'll have to think about this more and probably try a few things out.
- Rename failinject to failures - Use Enum for FailureType options - Add failures extra install options - Include base app name and config options in FailureInjectionConfig - Register failure task functions to avoid submitting branch new functions to engine each time - Change FailureInjectionEngine to use provided engine directly rather than reinitializing new engine - Update the docs page with new usage instructions and warnings Co-authored-by: Sicheng Zhou <[email protected]>
Contributor
|
@ClaudiaCumberbatch, I've addressed the configuration problem. You can now run the app like: python -m taps.run --app failures \
--app.base cholesky \
--app.config '{"matrix_size": 100, "block_size": 50}' \
--app.failure-rate 0.5 --app.failure-type dependency \
--engine.executor process-pool --engine.executor.max-processes 4
I made some other changes to get the branch ready to merge. Let me know if you have any questions about any of the changes I made. Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add failure injection workflow.
Fixes
Type of Change
Testing
N/A
Pull Request Checklist
Please confirm the PR meets the following requirements.
pre-commit(e.g., ruff, mypy, etc.).