Conversation
There is a lot of tricky code there that I marked as private with underscores, but I think the entire module should be marked private to avoid third-party code depending on it. In other words, the parsing code is so specific to taps.run that no one else should use it and there will very likely be internally breaking changes in the future to support new features.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a complete rework of the plugin and CLI configuration system. The initial goal was to support configuration files, which ended up being non-trivial to do.
The resulting refactor now supports the following features:
EngineConfigclass@register(kind)decorator--configoption to load a base configuration from a TOML fileA lot of items were renamed or moved around, so this is a very breaking change. The CLI arguments have also changed so all docs have been updated.
Fixes
Type of Change
Testing
Extensively tested with new unit tests and running the CLI with various combinations of options.
Pull Request Checklist
Please confirm the PR meets the following requirements.
pre-commit(e.g., ruff, mypy, etc.).