Skip to content

Add TaskVine executor support#174

Merged
gpauloski merged 1 commit intomainfrom
issue-19
Oct 23, 2024
Merged

Add TaskVine executor support#174
gpauloski merged 1 commit intomainfrom
issue-19

Conversation

@gpauloski
Copy link
Copy Markdown
Contributor

Description

Add TaskVine as an executor within TaPS. The customized TaskVineExecutor supports normal and serverless modes within TaskVine.

This includes unit tests but they will be skipped in CI because TaskVine requires Conda to be installed and the test suite runs in a normal Python virtual environment. This is unfortunate as we won't be testing regularly against future cctools updates, but hopefully this can be addressed in #161.

Fixes

Type of Change

  • Bug (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Internal (refactoring, performance, and testing)
  • Breaking (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (no changes to the code)
  • Development (CI workflows, packages, templates, etc.)
  • Package (package dependencies and versions)

Testing

Added unit tests that pass in a Conda environment that has TaskVine installed. Also tested the synthetic and cholesky apps.

Pull Request Checklist

Please confirm the PR meets the following requirements.

  • Relevant tags are added (breaking, bug, documentation, enhancement, package, etc.).
  • Code changes pass pre-commit (e.g., ruff, mypy, etc.).
  • Tests have been added to show the fix is effective or that the new feature works.
  • New and existing unit tests pass locally with the changes.
  • Docs have been updated and reviewed if relevant.

This includes unit tests but they will be skipped in CI because TaskVine
requires Conda to be installed and the test suite runs in a normal
Python virtual environment.
@gpauloski gpauloski added the enhancement New features or improvements to existing functionality label Oct 23, 2024
@gpauloski gpauloski merged commit 71a1f33 into main Oct 23, 2024
@gpauloski gpauloski deleted the issue-19 branch October 23, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or improvements to existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add TaskVine support

1 participant