Conversation
This includes unit tests but they will be skipped in CI because TaskVine requires Conda to be installed and the test suite runs in a normal Python virtual environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add TaskVine as an executor within TaPS. The customized
TaskVineExecutorsupports normal and serverless modes within TaskVine.This includes unit tests but they will be skipped in CI because TaskVine requires Conda to be installed and the test suite runs in a normal Python virtual environment. This is unfortunate as we won't be testing regularly against future cctools updates, but hopefully this can be addressed in #161.
Fixes
Type of Change
Testing
Added unit tests that pass in a Conda environment that has TaskVine installed. Also tested the synthetic and cholesky apps.
Pull Request Checklist
Please confirm the PR meets the following requirements.
pre-commit(e.g., ruff, mypy, etc.).