Fill dill serialization of tasks when using the failures app#163
Merged
Fill dill serialization of tasks when using the failures app#163
failures app#163Conversation
This is related to #155 which reported errors when dill attempted to serialize the closure task wrappers for failure task injection. These closures were serialized by value which caused issues with type annotations containing pydantic models which use ABCs, and dill 0.3.6, required by Globus Compute, can't pickle ABCs. Changing the closures to top-level functions and using functools.partial to inject the real task and the failure function resolves these serialization problems; everything can now be serialized by reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is related to #155 which reported errors when dill attempted to serialize the closure task wrappers for failure task injection. These closures were serialized by value which caused issues with type annotations containing pydantic models which use ABCs, and dill 0.3.6, required by Globus Compute, can't pickle ABCs.
This PR addresses two aspects of this problem:
BaseModels to dataclasses. This reverts CreateConfigdocstrings fromFielddescriptions #137.I also caught a bug in how
_dependency_failure_parent_taskwas called. It was used like a task factory, but was incorrectly wrapped in the@taskdecorator.Fixes
parsl.serialize.errors.SerializationErrorwhen using Parsl htex to run docking and moldesign #155Type of Change
Testing
Tested the cholesky app alone and with failure injection using Dask, Process Pool, Ray, and Parsl. I also tested the failure modes for dependency and import which have different task wrappers.
Pull Request Checklist
Please confirm the PR meets the following requirements.
pre-commit(e.g., ruff, mypy, etc.).