Skip to content

Fix not fully defined pydantic model Client of fedlearn app#153

Merged
gpauloski merged 1 commit intomainfrom
issue-152
Sep 9, 2024
Merged

Fix not fully defined pydantic model Client of fedlearn app#153
gpauloski merged 1 commit intomainfrom
issue-152

Conversation

@gpauloski
Copy link
Copy Markdown
Contributor

Description

I think I accidentally introduced this error when trying to make DataChoices importable without requiring torch to be installed. But this meant the types of the Client model for pydantic were only available at type checking time (not runtime).

Fixes

Type of Change

  • Bug (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Internal (refactoring, performance, and testing)
  • Breaking (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (no changes to the code)
  • Development (CI workflows, packages, templates, etc.)
  • Package (package dependencies and versions)

Testing

Ran the example in the docs.

Pull Request Checklist

Please confirm the PR meets the following requirements.

  • Relevant tags are added (breaking, bug, documentation, enhancement, package, etc.).
  • Code changes pass pre-commit (e.g., ruff, mypy, etc.).
  • Tests have been added to show the fix is effective or that the new feature works.
  • New and existing unit tests pass locally with the changes.
  • Docs have been updated and reviewed if relevant.

@gpauloski gpauloski added the bug Something isn't working label Sep 9, 2024
@gpauloski gpauloski changed the title Fix not fully defined pydantic model Client (#152) Fix not fully defined pydantic model Client of fedlearn app Sep 9, 2024
@gpauloski gpauloski merged commit a7001b3 into main Sep 9, 2024
@gpauloski gpauloski deleted the issue-152 branch September 9, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get pydantic.errors.PydanticUserError when running fedlearn using default configuration provided in the doc

1 participant