Fix concurrency bug in FutureDependencyExecutor#145
Merged
Conversation
The FutureDependencyExecutor constructor has two subtle bugs it: - Future callbacks were added before adding the future to the pending futures list which caused assertion errors in the callback if the callback was executed between those two lines. - _submit() could get called twice if there were pending futures that were already finished (so the callback was invoked immediately when the callback was added). These were causing deadlocks on Python 3.12 in the taps/apps/synthetic_test.py::run_sequential, but only when run in GitHub actions. I was not able to reproduce the deadlock locally but the logic error was apparent. I also noticed that we check for future arguments using Future rather than FutureProtocol. FutureProtocol was added later and is safer for executors that implement their own future type. Due to FutureProtocol now being used outside of taps.engine and a recursive import error, I moved taps.engine.future to taps.future.
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Python 3.12 tests were deadlocking in CI. This turned out to be the proble,
See the commit history for full details. I also made tests in CI run in verbose mode, and found a test dir with a missing
__init__.py. Both of these were attempts to find the true source of the test deadlocks---theFutureDependencyError.Fixes N/A
Type of Change
Testing
N/A
Pull Request Checklist
Please confirm the PR meets the following requirements.
pre-commit(e.g., ruff, mypy, etc.).