Allow multiple Parsl HTEx executors in ParslHTExConfig#142
Merged
gpauloski merged 1 commit intoproxystore:mainfrom Sep 9, 2024
Merged
Allow multiple Parsl HTEx executors in ParslHTExConfig#142gpauloski merged 1 commit intoproxystore:mainfrom
ParslHTExConfig#142gpauloski merged 1 commit intoproxystore:mainfrom
Conversation
Contributor
|
Hey, @ClaudiaCumberbatch! Do you want me to review this now, or are you still working on this branch? |
Contributor
Author
|
Hi Greg, I think I have finished adding this new feature so you can review it now. Thanks! |
gpauloski
requested changes
Sep 6, 2024
Contributor
gpauloski
left a comment
gpauloski
left a comment
There was a problem hiding this comment.
Thanks, Sicheng! I left to minor requests for changes.
Do you know what a multi-htex config file ends up looking like? I am curious.
Contributor
Author
|
Here is the [app]
name = "failures"
base = "cholesky"
failure_rate = 0
failure_type = "worker-killed"
[app.config]
matrix_size = 100
block_size = 50
[engine.executor]
name = "parsl-htex"
retries = 3
[engine.executor.htex.exe1]
max_workers = 4
radio_mode = "filesystem"
[engine.executor.htex.exe1.provider]
kind = "LSFProvider"
init_blocks = 1
max_blocks = 1
min_blocks = 1
nodes_per_block = 1
queue = "debug"
walltime = "00:30:00"
[engine.executor.htex.exe2]
max_workers = 4
radio_mode = "filesystem"
[engine.executor.htex.exe2.provider]
kind = "LSFProvider"
init_blocks = 1
max_blocks = 1
min_blocks = 1
nodes_per_block = 1
queue = "debug"
walltime = "00:30:00"
[engine.executor.monitoring]
hub_address = "localhost"
logging_endpoint = 'sqlite:///parsl-runinfo/monitoring.db'
resource_monitoring_interval = 1
hub_port = 55055 |
Contributor
Author
|
For now, I have updated the signature of |
Contributor
|
Thanks, @ClaudiaCumberbatch! Looks good, and the example config is good to have here in case anyone wants to refer back to it. |
gpauloski
approved these changes
Sep 9, 2024
gpauloski
changed the title
ParslHTExConfig
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes
Type of Change
Testing
N/A
Pull Request Checklist
Please confirm the PR meets the following requirements.
pre-commit(e.g., ruff, mypy, etc.).