Skip to content

Add manager_selector to Parsl HTEx config#118

Merged
gpauloski merged 3 commits intoproxystore:mainfrom
matthewc2003:add_manager_selector_config
Aug 6, 2024
Merged

Add manager_selector to Parsl HTEx config#118
gpauloski merged 3 commits intoproxystore:mainfrom
matthewc2003:add_manager_selector_config

Conversation

@matthewc2003
Copy link
Copy Markdown
Contributor

@matthewc2003 matthewc2003 commented Aug 2, 2024

Description

Add ManagerSelector: Optional[ManagerSelectorConfig]
This is used by the Parsl HTEX which requires a ManagerSelector object to be passed into the config
Add support for 'address_by_hostname' for the 'hub_address' field in the MonitoringConfig, uses AddressConfig
Adds additional tests to validate the functionality of ManagerSelectorConfig and 'hub_address'

Fixes

N/a

Type of Change

  • Bug (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Internal (refactoring, performance, and testing)
  • Breaking (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (no changes to the code)
  • Development (CI workflows, packages, templates, etc.)
  • Package (package dependencies and versions)

Testing

N/A

Pull Request Checklist

Please confirm the PR meets the following requirements.

  • Relevant tags are added (breaking, bug, documentation, enhancement, package, etc.).
  • Code changes pass pre-commit (e.g., ruff, mypy, etc.).
  • Tests have been added to show the fix is effective or that the new feature works.
  • New and existing unit tests pass locally with the changes.
  • Docs have been updated and reviewed if relevant.

@gpauloski gpauloski force-pushed the add_manager_selector_config branch from 543390e to 0545559 Compare August 6, 2024 15:19
@gpauloski gpauloski marked this pull request as ready for review August 6, 2024 15:19
@gpauloski gpauloski changed the title Add manager selector config and tests Add manager_selector to Parsl HTEx config Aug 6, 2024
@gpauloski gpauloski added the enhancement New features or improvements to existing functionality label Aug 6, 2024
@gpauloski gpauloski merged commit 1e71647 into proxystore:main Aug 6, 2024
@gpauloski
Copy link
Copy Markdown
Contributor

Thanks for the PR, @matthewc2003!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or improvements to existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants