Skip to content

Refactor taps.engine module layout#115

Merged
gpauloski merged 5 commits intomainfrom
task-wrapper-refactor
Aug 2, 2024
Merged

Refactor taps.engine module layout#115
gpauloski merged 5 commits intomainfrom
task-wrapper-refactor

Conversation

@gpauloski
Copy link
Copy Markdown
Contributor

Description

This refactor does a few things:

Generally there are no breaking changes to any app code.

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (internal implementation changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (no changes to the code)
  • CI change (changes to CI workflows, packages, templates, etc.)
  • Version changes (changes to the package or dependency versions)

Testing

All tests pass.

Pull Request Checklist

Please confirm the PR meets the following requirements.

  • Relevant tags are added (breaking, bug, dependencies, documentation, enhancement, refactor).
  • Code changes pass pre-commit (e.g., ruff, mypy, etc.).
  • Tests have been added to show the fix is effective or that the new feature works.
  • New and existing unit tests pass locally with the changes.
  • Docs have been updated and reviewed if relevant.

@gpauloski gpauloski added the internal Refactoring, style changes, testing, or code optimizations label Aug 2, 2024
@gpauloski gpauloski force-pushed the task-wrapper-refactor branch from ec582c4 to 1d4b0f5 Compare August 2, 2024 17:06
@gpauloski gpauloski merged commit 26f4109 into main Aug 2, 2024
@gpauloski gpauloski deleted the task-wrapper-refactor branch August 2, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Refactoring, style changes, testing, or code optimizations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Registered _TaskWrappers in Engine are specific to a task ID

1 participant