Skip to content

Fix Dask Futures getting proxied in chained tasks#113

Merged
gpauloski merged 2 commits intomainfrom
issue-112
Aug 1, 2024
Merged

Fix Dask Futures getting proxied in chained tasks#113
gpauloski merged 2 commits intomainfrom
issue-112

Conversation

@gpauloski
Copy link
Copy Markdown
Contributor

Description

Checking isinstance(obj, Future) does not work with Dask futures so the data transformer was getting incorrectly applied to futures.

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (internal implementation changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (no changes to the code)
  • CI change (changes to CI workflows, packages, templates, etc.)
  • Version changes (changes to the package or dependency versions)

Testing

The cholesky example from #112 works now.

Pull Request Checklist

Please confirm the PR meets the following requirements.

  • Relevant tags are added (breaking, bug, dependencies, documentation, enhancement, refactor).
  • Code changes pass pre-commit (e.g., ruff, mypy, etc.).
  • Tests have been added to show the fix is effective or that the new feature works.
  • New and existing unit tests pass locally with the changes.
  • Docs have been updated and reviewed if relevant.

@gpauloski gpauloski added the bug Something isn't working label Aug 1, 2024
@gpauloski gpauloski merged commit 8a1786e into main Aug 1, 2024
@gpauloski gpauloski deleted the issue-112 branch August 1, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MapReduce and Cholesky ProxyStore errors

1 participant