Skip to content

Add monitoring config to Parsl HTEx#106

Merged
gpauloski merged 2 commits intoproxystore:mainfrom
ClaudiaCumberbatch:for_PR
Jul 29, 2024
Merged

Add monitoring config to Parsl HTEx#106
gpauloski merged 2 commits intoproxystore:mainfrom
ClaudiaCumberbatch:for_PR

Conversation

@ClaudiaCumberbatch
Copy link
Copy Markdown
Contributor

Description

Add monitoring: Optional[MonitoringConfig]

Fixes

  • Fixes #XX
  • Fixes #XX

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (internal implementation changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (no changes to the code)
  • CI change (changes to CI workflows, packages, templates, etc.)
  • Version changes (changes to the package or dependency versions)

Testing

N/A

Pull Request Checklist

Please confirm the PR meets the following requirements.

  • Relevant tags are added (breaking, bug, dependencies, documentation, enhancement, refactor).
  • Code changes pass pre-commit (e.g., ruff, mypy, etc.).
  • Tests have been added to show the fix is effective or that the new feature works.
  • New and existing unit tests pass locally with the changes.
  • Docs have been updated and reviewed if relevant.

@ClaudiaCumberbatch ClaudiaCumberbatch marked this pull request as draft July 27, 2024 01:54
@ClaudiaCumberbatch ClaudiaCumberbatch marked this pull request as ready for review July 27, 2024 04:08
@gpauloski gpauloski changed the title Add monitoring: Optional[MonitoringConfig] Add monitoring config to Parsl HTEx Jul 29, 2024
@gpauloski
Copy link
Copy Markdown
Contributor

Thanks, @ClaudiaCumberbatch! I fixed a small bug and added some tests.

@gpauloski gpauloski merged commit 6fb7fc0 into proxystore:main Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants