Ignore extra options in engine plugin configs

gpauloski · gpauloski · commit df1be9fe6b68 · 2024-07-05T14:40:55.000-05:00
Forbidding extra options in the engine plugin configs (executor, filter,
and transformer) meant that trying to override the plugin type defined
in a config file from a CLI argument would raise an "extra options
forbidden" error by the pydantic validators because of the options for
the not used plugin variant in the config.

This change should support that use case. Note that the run Config and
AppConfig still forbid extra options as a sanity check, and those don't
have the same issue of wanting to frequently switch the plugin type.
diff --git a/taps/executor/config.py b/taps/executor/config.py
@@ -13,7 +13,7 @@ class ExecutorConfig(BaseModel, abc.ABC):
     name: str
 
     model_config: ConfigDict = ConfigDict(  # type: ignore[misc]
-        extra='forbid',
+        extra='ignore',
         validate_default=True,
         validate_return=True,
     )
diff --git a/taps/filter/config.py b/taps/filter/config.py
@@ -21,7 +21,7 @@ class FilterConfig(BaseModel, abc.ABC):
     name: str = Field(description='name of filter type')
 
     model_config: ConfigDict = ConfigDict(  # type: ignore[misc]
-        extra='forbid',
+        extra='ignore',
         validate_default=True,
         validate_return=True,
     )
diff --git a/taps/transformer/config.py b/taps/transformer/config.py
@@ -16,7 +16,7 @@ class TransformerConfig(BaseModel, abc.ABC):
     name: str = Field(description='name of transformer type')
 
     model_config: ConfigDict = ConfigDict(  # type: ignore[misc]
-        extra='forbid',
+        extra='ignore',
         validate_default=True,
         validate_return=True,
     )

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ class ExecutorConfig(BaseModel, abc.ABC):`
`13`	`13`	`name: str`
`14`	`14`
`15`	`15`	`model_config: ConfigDict = ConfigDict( # type: ignore[misc]`
`16`		`- extra='forbid',`
	`16`	`+ extra='ignore',`
`17`	`17`	`validate_default=True,`
`18`	`18`	`validate_return=True,`
`19`	`19`	`)`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ class FilterConfig(BaseModel, abc.ABC):`
`21`	`21`	`name: str = Field(description='name of filter type')`
`22`	`22`
`23`	`23`	`model_config: ConfigDict = ConfigDict( # type: ignore[misc]`
`24`		`- extra='forbid',`
	`24`	`+ extra='ignore',`
`25`	`25`	`validate_default=True,`
`26`	`26`	`validate_return=True,`
`27`	`27`	`)`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ class TransformerConfig(BaseModel, abc.ABC):`
`16`	`16`	`name: str = Field(description='name of transformer type')`
`17`	`17`
`18`	`18`	`model_config: ConfigDict = ConfigDict( # type: ignore[misc]`
`19`		`- extra='forbid',`
	`19`	`+ extra='ignore',`
`20`	`20`	`validate_default=True,`
`21`	`21`	`validate_return=True,`
`22`	`22`	`)`