Skip to content

Make StoreConfig a Pydantic BaseModel#589

Merged
gpauloski merged 1 commit intomainfrom
issue-584
Jun 26, 2024
Merged

Make StoreConfig a Pydantic BaseModel#589
gpauloski merged 1 commit intomainfrom
issue-584

Conversation

@gpauloski
Copy link
Copy Markdown
Collaborator

Description

Make StoreConfig a Pydantic BaseModel. The StoreConfig now has write_toml and from_toml methods for saving and reusing Store configurations.

This should not be a breaking change because StoreConfig previously stated that it should not be instantiated directly, only via Store.config().

Fixes

Type of Change

  • Breaking Change (fix or enhancement which changes existing semantics of the public interface)
  • Enhancement (new features or improvements to existing functionality)
  • Bug (fixes for a bug or issue)
  • Internal (refactoring, style changes, testing, optimizations)
  • Documentation update (changes to documentation or examples)
  • Package (dependencies, versions, package metadata)
  • Development (CI workflows, pre-commit, linters, templates)
  • Security (security related changes)

Testing

Added new tests.

Pull Request Checklist

Please confirm the PR meets the following requirements.

  • Tags added to PR (e.g., breaking, bug, enhancement, internal, documentation, package, development, security).
  • Code changes pass pre-commit (e.g., mypy, ruff, etc.).
  • Tests have been added to show the fix is effective or that the new feature works.
  • New and existing unit tests pass locally with the changes.
  • Docs have been updated and reviewed if relevant.

@gpauloski gpauloski added the enhancement New features or improvements to existing functionality label Jun 26, 2024
@gpauloski gpauloski merged commit bd2b502 into main Jun 26, 2024
@gpauloski gpauloski deleted the issue-584 branch June 26, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or improvements to existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Turn StoreConfig into Pydantic BaseModel

1 participant