fix: convert native PHP floats to single precision#8187
Merged
haberman merged 2 commits intoprotocolbuffers:masterfrom Jan 11, 2021
Merged
fix: convert native PHP floats to single precision#8187haberman merged 2 commits intoprotocolbuffers:masterfrom
haberman merged 2 commits intoprotocolbuffers:masterfrom
Conversation
Member
|
This PR looks reasonable to me on first glance, but appears to cause some test failures. @bshaffer want to investigate? |
Contributor
Author
|
@haberman I unfortunately can't see the details of the failing tests - getting 404s on both of them when I click "Details". Running the tests locally now to investigate... |
Contributor
Author
|
The failing tests are for Ruby, which was not effected by this change, so I think they're just flakey. |
Member
|
The Ruby 3.0 tests are brand new, we can disregard them until #8134 is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #8165
Converts PHP double-precision floats to single-precision for consistency with the protobuf C-extension