js/binary/utils.js: Fix jspb.utils.joinUnsignedDecimalString to work with negative bitsLow and low but non-zero bitsHigh parameter.#8170
Merged
perezd merged 1 commit intoprotocolbuffers:masterfrom Jan 8, 2021
Conversation
…with negative bitsLow and low but non-zero bitsHigh parameter.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Contributor
Author
|
@googlebot I signed it! |
perezd
approved these changes
Jan 7, 2021
Contributor
perezd
left a comment
perezd
left a comment
There was a problem hiding this comment.
LGTM, thank you for your contribution!
shaod2
approved these changes
Jan 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We noticed that our generated javascript message implementations decode certain number fields incorrectly for some values when the fields have
jstype = JS_STRING. I tracked it down toreadZigzagVarint64String(), which does not always decode a field correctly. In particular, it returns the wrong result when it calls intojspb.utils.joinUnsignedDecimalStringwith abitsLowvalue that is negative and abitsHighvalue that is less than0x1FFFFF. None of the existing test cases appear to cover that case.This PR changes
joinUnsignedDecimalStringto calljspb.utils.joinUint64on its fast path instead, which gets us the right result.It's also possible to change the line to
or similar instead.
This is my first contact with this code and it wasn't clear to me if the bug is actually in the caller of
joinUnsignedDecimalString. IfjoinUnsignedDecimalStringis expecting purely unsigned parameters then it's possible that this isn't the desired fix. But it would be great if we could get a fix landed :).Thanks for the awesome project which we make great use of throughout our stack :).