Ruby: encode repeated field in packed format if desired#7381
Closed
qnighy wants to merge 1 commit intoprotocolbuffers:masterfrom
Closed
Ruby: encode repeated field in packed format if desired#7381qnighy wants to merge 1 commit intoprotocolbuffers:masterfrom
qnighy wants to merge 1 commit intoprotocolbuffers:masterfrom
Conversation
Member
|
I'm somewhat reluctant to keep going down the path of adding more and more complexity to the DSL. Even if we fix this, we already know there are N more things that the DSL still doesn't cover. Worse, the DSL will never be able to capture 100% of the information in a protobuf descriptor. Custom options can be self-referential, so it in some cases it will not be possible to specify these cleanly in the DSL. If the generated code simply embedded a binary descriptor, we would have perfect fidelity and we would never have to fix the DSL again. But we'd give up the readability of the DSL. Perhaps the .proto file could be embedded in comments? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds
packed: true/packed: falseoptions torepeateddescriptor declaration, and uses that information when encoding packable fields.TODO: implementation for JRuby