Update protobuf version#6898
Merged
rafi-kamal merged 1 commit intoprotocolbuffers:masterfrom Nov 16, 2019
Merged
Conversation
Contributor
Author
|
@TeBoring some the PHP files have changed. Do you know why? |
Contributor
|
My php fix has some protoc change. That’s expected
…On Fri, Nov 15, 2019 at 11:51 Rafi Kamal ***@***.***> wrote:
@TeBoring <https://github.com/TeBoring> some the PHP files have changed.
Do you know why?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6898?email_source=notifications&email_token=ABHUPZJN4O2S2XGGDH2KUE3QT34VLA5CNFSM4JN7O5A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEGQ4CI#issuecomment-554503689>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABHUPZNQEZELWTFCKGMUUNLQT34VLANCNFSM4JN7O5AQ>
.
|
Contributor
Author
|
The Bazel tests are failing with the following error: @ejona86 could this be related to the javalite stuffs you have been working on? |
Contributor
Author
|
Actually, the failure seems to be unrelated to Eric's change (grpc/grpc-java#6424). That change was submitting yesterday, our tests started failing from this noon (https://g3c.corp.google.com/results/invocations;query=protobuf%2Fgithub%2Fmaster%2Fubuntu%2Fbazel%2Fpresubmit). |
Contributor
Author
|
Looks like our javalite branch got vanished somehow. I've restored the branch, hopefully that will fix the error. |
rafi-kamal
added a commit
that referenced
this pull request
Nov 19, 2019
nlhien
pushed a commit
to nlhien/protobuf
that referenced
this pull request
Feb 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.