Document proto2 feature implementations in Google.Protobuf#6499
Merged
jtattermusch merged 4 commits intoprotocolbuffers:masterfrom Sep 3, 2019
Merged
Conversation
Contributor
jtattermusch
left a comment
jtattermusch
left a comment
There was a problem hiding this comment.
Thanks for the documentation! Overall it's looking pretty good, but adding a bunch of suggestions for improvements anyway.
Addressed review comments
Reworded info about message initialization
Contributor
Author
|
I've addressed your review comments @jtattermusch |
jtattermusch
reviewed
Sep 3, 2019
Contributor
jtattermusch
left a comment
jtattermusch
left a comment
There was a problem hiding this comment.
LGTM after fixing one last comment.
I think we will merge this together with #5936.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jtattermusch