Skip to content

Backport review comments for C# proto2 features (for 3.9.x)#6431

Merged
jtattermusch merged 4 commits intoprotocolbuffers:3.9.xfrom
jtattermusch:backport_csharp_proto2_review
Jul 25, 2019
Merged

Backport review comments for C# proto2 features (for 3.9.x)#6431
jtattermusch merged 4 commits intoprotocolbuffers:3.9.xfrom
jtattermusch:backport_csharp_proto2_review

Conversation

@jtattermusch
Copy link
Copy Markdown
Contributor

Most importantly, the new extension APIs are marked as experimental so that we can do some minor adjustments in 3.10 if needed.

@googlebot
Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@jtattermusch
Copy link
Copy Markdown
Contributor Author

CC @ObsidianMinor

@googlebot
Copy link
Copy Markdown

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@jtattermusch jtattermusch merged commit bc5f088 into protocolbuffers:3.9.x Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants