Repository navigation
Conversation
Check that a linked message fasttable slot matches the actual tag before looking up the subtable or entering the message path. This keeps mismatched tags on the fallback path and avoids rejecting valid unknown fields at an exact recursion boundary. Signed-off-by: David Sarkisyan <[email protected]>
Contributor
Author
|
The fork CI log says a protobuf team member needs to review this change and add |
sbenzaquen
added
the
🅰️ safe for tests
github-actions
Bot
removed
the
🅰️ safe for tests
haberman
approved these changes
Oct 13, 2026
Signed-off-by: David Sarkisyan <[email protected]>
Contributor
Author
|
Thanks for the review. I merged current main into the branch and reran the decoder tests locally. The focused regression and all 203 tests in //upb/wire:decode_test pass with fasttable enabled. The new commit needs a fresh |
karenwuz
added
the
🅰️ safe for tests
github-actions
Bot
removed
the
🅰️ safe for tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Without this ordering, the fast decoder can return
MaxDepthExceededfor a valid message that the generic decoder accepts because it consumes depth before discovering that the tag does not match the message slot.Testing
DecodeTest.MismatchedMessageSlotDoesNotConsumeDepthpasses with the fast and generic decoders.upb-test: 535 passed, 1 existing skip.