Fix missing std::tr1::hash on GCC 4.1#2906
Closed
matthauck wants to merge 1 commit intoprotocolbuffers:masterfrom
Closed
Fix missing std::tr1::hash on GCC 4.1#2906matthauck wants to merge 1 commit intoprotocolbuffers:masterfrom
matthauck wants to merge 1 commit intoprotocolbuffers:masterfrom
Conversation
Rather than crashing on use (doh!) better to just implement the missing std::tr1::hash structs. Fixes regression introduced by protocolbuffers#1913
|
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure. |
1 similar comment
|
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure. |
|
Can one of the admins verify this patch? |
Contributor
|
ok to test |
Contributor
|
Closing this in favor of #2907 because the hash function in this PR seems too weak. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than crashing on use (doh!) better to just implement the
missing std::tr1::hash structs.
Fixes regression introduced by #1913