Fix: Apply path traversal guard to WriteAllToZip() matching WriteAllToDisk()#27171
Closed
mrknight-n1du wants to merge 3 commits into
Closed
Fix: Apply path traversal guard to WriteAllToZip() matching WriteAllToDisk()#27171mrknight-n1du wants to merge 3 commits into
mrknight-n1du wants to merge 3 commits into
Conversation
Add validation to prevent relative paths in output file names.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
Author
|
Updated the PR as suggested — changed from hard error to warning, |
github-actions
Bot
removed
the
🅰️ safe for tests
Contributor
Author
|
It's my pleasure, @esrauchg. Any update on when this will be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies the same path traversal guard already present in
WriteAllToDisk()toWriteAllToZip(). A plugin returninga filename like
../../PWNED.txtis blocked for directory output,but currently slips silently into an archive, enabling Zip Slip-style entries.
This fix adds an identical
..check and returns an error to preventtraversal injection in .zip / .jar / .srcjar output.
Closes #27170