Fix csharp string interpolation in Timestamp.ToDateTime() exception message#26341
Closed
tyulpan wants to merge 2 commits into
Closed
Fix csharp string interpolation in Timestamp.ToDateTime() exception message#26341tyulpan wants to merge 2 commits into
csharp string interpolation in Timestamp.ToDateTime() exception message#26341tyulpan wants to merge 2 commits into
Conversation
Contributor
|
We already had a PR for this, #26270. I'm not sure what's happened to that at the moment. @mkruskal-google you approved that 4 days ago - do you know why it's not found any more? |
Member
|
It looks like that PR failed a test due to a flake, and the user deleted their fork prior before the PR got unstuck / merged which closed the PR. |
zhangskz
added
the
🅰️ safe for tests
github-actions
Bot
removed
the
🅰️ safe for tests
jskeet
approved these changes
Mar 18, 2026
esrauchg
approved these changes
Mar 25, 2026
github-actions
Bot
removed
the
🅰️ safe for tests
esrauchg
approved these changes
Apr 21, 2026
esrauchg
added
the
🅰️ safe for tests
github-actions
Bot
removed
the
🅰️ safe for tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change a verbatim string literal
@""to an interpolated string$""inTimestamp.ToDateTime()exception message.Resolves #26006.