Fix string interpolation in Timestamp error message#26270
Closed
04cb wants to merge 2 commits into
Closed
Conversation
jskeet
reviewed
Mar 8, 2026
jskeet
left a comment
jskeet
left a comment
Contributor
There was a problem hiding this comment.
Whoops, that's embarrassing. Would you be happy to adjust the test (csharp/src/Google.Protobuf.Test/WellKnownTypes/TimestampTest.cs line 46) as well? (Possibly just check that the message contains the string values of both seconds and nanoseconds, rather than asserting an exact message?)
Contributor
|
(Adding Mike to merge if he's happy.) |
mkruskal-google
added
the
🅰️ safe for tests
github-actions
Bot
removed
the
🅰️ safe for tests
mkruskal-google
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26006. Changed @ to $ for string interpolation so the error message displays actual values for Seconds and Nanos instead of literal placeholders.