chore: add a unit test for .github/release_prep.sh#26247
Closed
alexeagle wants to merge 8 commits into
Closed
Conversation
| echo "should be excluded" > compatibility/README | ||
| echo "# protobuf" > README.md | ||
|
|
||
| git add -A |
Member
There was a problem hiding this comment.
Does this work in bazel??
Contributor
Author
There was a problem hiding this comment.
sure, the sandbox doesn't prevent test actions from executing arbitrary binaries on the PATH
Member
|
The new test seems to fail in multiple configurations, but not giving any observable indication of why: |
acozzette
force-pushed
the
test_release_sh
branch
from
June 26, 2026 19:55
61b4bb2 to
c748113
Compare
acozzette
force-pushed
the
test_release_sh
branch
from
June 26, 2026 20:53
483d85a to
ca6b714
Compare
Collaborator
|
@mkruskal-google I got the test to pass and I think this is now ready for another look. |
mkruskal-google
approved these changes
Jun 30, 2026
protobuf-team-bot
added a commit
that referenced
this pull request
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by protobuf team after having a rough time in v34.0 release