fix(cpp): stop TextFormat iteration if output stream fails#26237
Closed
jschroedr wants to merge 4 commits into
Closed
fix(cpp): stop TextFormat iteration if output stream fails#26237jschroedr wants to merge 4 commits into
jschroedr wants to merge 4 commits into
Conversation
Contributor
|
Looks like you're out of date. Would you mind:
Thanks |
Contributor
Author
|
Hi @honglooker - confirming I've added a test showing how the update prevents TextFormat from printing beyond the point of failure. More specifically, the test stops exactly at the failure limit of 64 bytes and makes one attempt after failure, turning O(N) work into O(1) work once the output destination is reached. Note: I've included the verification in a standalone test file to ensure a clean build environment independent of the current experimental features in the main test suite. |
jschroedr
force-pushed
the
bugfix/#23288
branch
from
March 12, 2026 02:07
1c02d7f to
1f2f1d3
Compare
github-actions
Bot
added
untriaged
Contributor
|
Huh, I recall the CLA being ✅ a few days ago - now it's red? You'll need to sign that before we proceed, thank you (maybe different email?) |
honglooker
added
cla: no
and removed
untriaged
jschroedr
force-pushed
the
bugfix/#23288
branch
from
March 16, 2026 23:59
1f2f1d3 to
fb37c09
Compare
Contributor
Author
|
All set now @honglooker |
Contributor
Author
|
Just updated with the base branch - please let me know if anything else is needed. |
JasonLunn
added
c++
text format
🅰️ safe for tests
github-actions
Bot
removed
the
🅰️ safe for tests
JasonLunn
requested changes
May 15, 2026
…cuiting early to prevent unnecessary work when the generator is in a failed state
Contributor
Author
|
Feedback has been addressed @JasonLunn - thank you for your time reviewing and please let me know if you need anything else. |
JasonLunn
added
the
🅰️ safe for tests
github-actions
Bot
removed
the
🅰️ safe for tests
JasonLunn
approved these changes
May 17, 2026
JasonLunn
added
🅰️ safe for tests
github-actions
Bot
removed
the
🅰️ safe for tests
protobuf-team-bot
added a commit
that referenced
this pull request
May 18, 2026
robot-piglet
pushed a commit
to userver-framework/userver
that referenced
this pull request
Jun 25, 2026
* Optimized @ref ugrpc::ToLimitedDebugString and logging middlewares for Protobuf v35+ (to be precise, [this](protocolbuffers/protobuf#26237) PR is required). * At the same time, this may introduce a performance regression for older Protobuf versions. Please measure on your workloads. In extreme cases, disabling the logging middleware or setting `msg-size-log-limit: 0` should help. userver/grpc/benchmarks: ``` BenchCustomLimit 6156 ns 6155 ns 112481 BenchCustomLimitExceptionBased 21486 ns 21485 ns 32497 ``` commit_hash:444433baa658f140354be31611d1a3e8698d623a
Malevrovich
pushed a commit
to Malevrovich/userver
that referenced
this pull request
Jul 3, 2026
* Optimized @ref ugrpc::ToLimitedDebugString and logging middlewares for Protobuf v35+ (to be precise, [this](protocolbuffers/protobuf#26237) PR is required). * At the same time, this may introduce a performance regression for older Protobuf versions. Please measure on your workloads. In extreme cases, disabling the logging middleware or setting `msg-size-log-limit: 0` should help. userver/grpc/benchmarks: ``` BenchCustomLimit 6156 ns 6155 ns 112481 BenchCustomLimitExceptionBased 21486 ns 21485 ns 32497 ``` commit_hash:444433baa658f140354be31611d1a3e8698d623a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TextFormat::Printer currently continues to iterate over fields and repeated elements even after the underlying ZeroCopyOutputStream returns false. This results in unnecessary CPU usage (reflection and formatting) for large messages.
This change:
Fixes: #23288