Skip to content

chore(php): fix php 8.5 deprecations 33.x#25714

Merged
mkruskal-google merged 2 commits into
33.xfrom
fix-php85-deprecations-33.x
Feb 6, 2026
Merged

chore(php): fix php 8.5 deprecations 33.x#25714
mkruskal-google merged 2 commits into
33.xfrom
fix-php85-deprecations-33.x

Conversation

@bshaffer

@bshaffer bshaffer commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

Submitting compatibility fixes for PHP 8.5 which were made to the main branch in #24668 and #24666 for the 33.x branch

These fixes are important for maintaining compatibility with 33.x for PHP 8.5

See also #24666 (comment) and googleapis/gax-php#644

(resubmitting from origin instead of the fork)

@bshaffer
bshaffer requested a review from a team as a code owner February 6, 2026 09:27
@bshaffer
bshaffer requested review from ericsalo and removed request for a team February 6, 2026 09:27
@mkruskal-google
mkruskal-google merged commit a594f97 into 33.x Feb 6, 2026
748 of 779 checks passed
@mkruskal-google
mkruskal-google deleted the fix-php85-deprecations-33.x branch February 6, 2026 17:30
@VincentLanglet

Copy link
Copy Markdown

Hi, this is currently not present in the 4.33.5 release and the 5.34.0 is not installed by other libraries
(example: https://packagist.org/packages/google/common-protos)

Could you release a 4.33.6 version with this @bshaffer ?

@bshaffer

bshaffer commented Mar 5, 2026

Copy link
Copy Markdown
Contributor Author

@VincentLanglet let me ask the team and see when it's expected to go out

@bshaffer

bshaffer commented Mar 6, 2026

Copy link
Copy Markdown
Contributor Author

@VincentLanglet The answer I got was "soonish" :)

I would estimate 1-2 weeks

@VincentLanglet

Copy link
Copy Markdown

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants