Skip to content

Update rules_apple dependency to support rules_swift 3.x#25437

Closed
luispadron wants to merge 3 commits intoprotocolbuffers:mainfrom
luispadron:luis/unblock-rules-apple-bazel-9
Closed

Update rules_apple dependency to support rules_swift 3.x#25437
luispadron wants to merge 3 commits intoprotocolbuffers:mainfrom
luispadron:luis/unblock-rules-apple-bazel-9

Conversation

@luispadron
Copy link
Contributor

rules_swift 3.x requires a compat level of 3 which was only supported in rules_apple 4.x+.

@luispadron
Copy link
Contributor Author

luispadron commented Jan 22, 2026

I was also surprised to see protobuf take a dep on rules_apple. I could only find one use in this repo for it. It sort of complicates how protobuf is used in rules_swift as it depends on protobuf which depends on rules_apple which itself depends on rules_swift

@meisterT
Copy link
Contributor

cc @jguamie

@jguamie jguamie requested a review from JasonLunn January 27, 2026 21:55
@JasonLunn JasonLunn added bazel 🅰️ safe for tests Mark a commit as safe to run presubmits over mac and removed 🅰️ safe for tests Mark a commit as safe to run presubmits over labels Jan 27, 2026
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jan 27, 2026
@JasonLunn
Copy link
Contributor

This PR is failing most of our windows platform tests. It looks like the absence of swiftc.exe was treated as a failure until rules_swift 3.0, when this commit landed, fixing bazelbuild/rules_swift#1483. The error message we see in the failures (No 'swiftc.exe' executable found in Path) doesn't exist in rules_swift any more, further hinting that the version of rules_swift being pulled in is out of date - maybe as old as 2.4.0, which is the current default.

Can you try including a bump to the version of rules_swift so that rules_apple pulls in a version with the fix?

@luispadron
Copy link
Contributor Author

luispadron commented Jan 27, 2026

@JasonLunn Hmm interesting. protobuf doesn't have a direct dep on rules_swift and I'm not sure it can? rules_swift has a dependency on protobuf. The version 2.x is being brought in by rules_apple transitively

@JasonLunn JasonLunn added 🅰️ safe for tests Mark a commit as safe to run presubmits over and removed wait for user action labels Jan 27, 2026
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jan 27, 2026
@luispadron
Copy link
Contributor Author

Pushed a change that uses an override to see if that helps

@JasonLunn JasonLunn added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jan 28, 2026
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jan 28, 2026
@luispadron luispadron requested a review from a team as a code owner January 28, 2026 01:26
@luispadron luispadron requested review from Logofile and removed request for a team January 28, 2026 01:26
@luispadron
Copy link
Contributor Author

luispadron commented Jan 28, 2026

Updated! I think we'll likely want to follow this up by providing a apple_binary rule in apple_support so we can drop the rules_apple dependency in this repo.

@JasonLunn JasonLunn added 🅰️ safe for tests Mark a commit as safe to run presubmits over and removed wait for user action labels Jan 28, 2026
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jan 28, 2026
copybara-service bot pushed a commit that referenced this pull request Jan 28, 2026
rules_swift 3.x requires a compat level of `3` which was only supported in rules_apple 4.x+.

Closes #25437

FUTURE_COPYBARA_INTEGRATE_REVIEW=#25437 from luispadron:luis/unblock-rules-apple-bazel-9 03cc5ec
PiperOrigin-RevId: 861987440
@luispadron
Copy link
Contributor Author

Not sure whats up with the other failing tests but they dont seem related to Bazel

copybara-service bot pushed a commit that referenced this pull request Jan 28, 2026
rules_swift 3.x requires a compat level of `3` which was only supported in rules_apple 4.x+.

Closes #25437

FUTURE_COPYBARA_INTEGRATE_REVIEW=#25437 from luispadron:luis/unblock-rules-apple-bazel-9 03cc5ec
PiperOrigin-RevId: 861987440
@luispadron
Copy link
Contributor Author

I see yall opened #25534, ill close this in favor of that one. I forgot circular deps are fine in bzlmod so i think were good here with the changes in that PR

@luispadron luispadron closed this Jan 28, 2026
@JasonLunn
Copy link
Contributor

No need to close this manually, automation will close this when a fix lands.

@JasonLunn JasonLunn reopened this Jan 28, 2026
copybara-service bot pushed a commit that referenced this pull request Jan 29, 2026
rules_swift 3.x requires a compat level of `3` which was only supported in rules_apple 4.x+.

Closes #25437

FUTURE_COPYBARA_INTEGRATE_REVIEW=#25437 from luispadron:luis/unblock-rules-apple-bazel-9 03cc5ec
PiperOrigin-RevId: 861987440
protobuf-team-bot added a commit that referenced this pull request Jan 29, 2026
JasonLunn pushed a commit that referenced this pull request Jan 29, 2026
rules_swift 3.x requires a compat level of `3` which was only supported in rules_apple 4.x+.

Closes #25437

PiperOrigin-RevId: 862515654
JasonLunn pushed a commit that referenced this pull request Jan 30, 2026
JasonLunn pushed a commit that referenced this pull request Jan 30, 2026
rules_swift 3.x requires a compat level of `3` which was only supported in rules_apple 4.x+.

Closes #25437

PiperOrigin-RevId: 862515654
JasonLunn pushed a commit that referenced this pull request Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants