feat(php): support default values for editions/proto2#25161
Closed
bshaffer wants to merge 9 commits intoprotocolbuffers:mainfrom
Closed
feat(php): support default values for editions/proto2#25161bshaffer wants to merge 9 commits intoprotocolbuffers:mainfrom
bshaffer wants to merge 9 commits intoprotocolbuffers:mainfrom
Conversation
github-actions
bot
removed
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
bshaffer
commented
Jan 5, 2026
github-actions
bot
removed
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
| case FieldDescriptor::CPPTYPE_STRING: | ||
| return "'" + absl::CEscape(field->default_value_string()) + "'"; | ||
| case FieldDescriptor::CPPTYPE_MESSAGE: | ||
| return "null"; |
Member
There was a problem hiding this comment.
This should be unreachable, might as well ABSL_CHECK
Contributor
Author
There was a problem hiding this comment.
Something like this?
Suggested change
| return "null"; | |
| ABSL_CHECK(false) << "Message fields cannot have default values."; | |
| return "null"; |
mkruskal-google
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/435022198