Removed wrap_memcpy.c compatibility shim for pre-2.14 glibc#22420
Merged
copybara-service[bot] merged 1 commit intomainfrom Jun 26, 2025
Merged
Removed wrap_memcpy.c compatibility shim for pre-2.14 glibc#22420copybara-service[bot] merged 1 commit intomainfrom
wrap_memcpy.c compatibility shim for pre-2.14 glibc#22420copybara-service[bot] merged 1 commit intomainfrom
Conversation
copybara-service
Bot
force-pushed
the
test_776175307
branch
from
d9ea2a6 to
bad3105
Compare
This shim was added in 2017 to make binary gems compatible with pre-2.14 glibc: #2804 glibc 2.14 was released in 2011. Our Python wheels build for manylinux 2014, which requires glibc 2.17 or later: https://github.com/pypa/manylinux?tab=readme-ov-file#manylinux2014-centos-7-based-glibc-217 We should no longer need binary compatibility with a 14-year-old glibc. Fixes: #11935 PiperOrigin-RevId: 776288819
copybara-service
Bot
force-pushed
the
test_776175307
branch
from
bad3105 to
4ba9733
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed
wrap_memcpy.ccompatibility shim for pre-2.14 glibcThis shim was added in 2017 to make binary gems compatible with pre-2.14 glibc: #2804
glibc 2.14 was released in 2011. Our Python wheels build for manylinux 2014, which requires glibc 2.17 or later: https://github.com/pypa/manylinux?tab=readme-ov-file#manylinux2014-centos-7-based-glibc-217
We should no longer need binary compatibility with a 14-year-old glibc.
Fixes: #11935