fix(bazel/python): incompatible_enable_proto_toolchain_resolution#17078
Closed
alexeagle wants to merge 1 commit intoprotocolbuffers:mainfrom
Closed
fix(bazel/python): incompatible_enable_proto_toolchain_resolution#17078alexeagle wants to merge 1 commit intoprotocolbuffers:mainfrom
alexeagle wants to merge 1 commit intoprotocolbuffers:mainfrom
Conversation
This was originally landed in bazel-contrib/rules_python#1577 However the fork of py_proto_library brought to the protobuf repo was from an earlier commit: 8257c44 (cl/623401031 for googlers) Thus the fix was lost. This PR simply cherry-picks that change.
mkruskal-google
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
Collaborator
Author
|
Note, @mkruskal-google agrees that the one test failure here is a known flake. |
comius
approved these changes
Jun 10, 2024
mkruskal-google
approved these changes
Jun 10, 2024
zhangskz
approved these changes
Jun 10, 2024
TinyTinni
pushed a commit
to TinyTinni/protobuf
that referenced
this pull request
Jun 15, 2024
…otocolbuffers#17078) This was originally landed in bazel-contrib/rules_python#1577 However the fork of py_proto_library brought to the protobuf repo was from an earlier commit: protocolbuffers@8257c44 (cl/623401031 for googlers) Thus the fix was lost. This PR simply cherry-picks that change. Closes protocolbuffers#17078 COPYBARA_INTEGRATE_REVIEW=protocolbuffers#17078 from alexeagle:py_proto_toolchain 226540e PiperOrigin-RevId: 642123868
deannagarcia
pushed a commit
to deannagarcia/protobuf
that referenced
this pull request
Jun 20, 2024
…otocolbuffers#17078) This was originally landed in bazel-contrib/rules_python#1577 However the fork of py_proto_library brought to the protobuf repo was from an earlier commit: protocolbuffers@8257c44 (cl/623401031 for googlers) Thus the fix was lost. This PR simply cherry-picks that change. Closes protocolbuffers#17078 COPYBARA_INTEGRATE_REVIEW=protocolbuffers#17078 from alexeagle:py_proto_toolchain 226540e PiperOrigin-RevId: 642123868
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was originally landed in bazel-contrib/rules_python#1577 However the fork of py_proto_library brought to the protobuf repo was from an earlier commit: 8257c44 (cl/623401031 for googlers)
Thus the fix was lost. This PR simply cherry-picks that change.