Cherry-Pick Add Automatic-Module-Name (#14562)#16388
Merged
Conversation
Adds Automatic-Module-Name after it was lost during the maven-bazel migration (and subsequent re-addition of osgi bundle support). Updates OsgiWrapper to support adding the Automatic-Module-Name header to the list of properties supported by the `osgi_java_library` rule. Fixes #12639 Closes #14562 COPYBARA_INTEGRATE_REVIEW=#14562 from Sineaggi:add-automatic-module-name a27b3e6 PiperOrigin-RevId: 579748655
zhangskz
requested review from
haberman,
mkruskal-google and
shaod2
and removed request for
a team
setup-php 2.30.0 should fix shivammathur/setup-php#823 PiperOrigin-RevId: 612882408
PiperOrigin-RevId: 594102279
zhangskz
changed the title
mkruskal-google
approved these changes
Apr 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of d580fde
Adds Automatic-Module-Name after it was lost during the maven-bazel migration (and subsequent re-addition of osgi bundle support).
Updates OsgiWrapper to support adding the Automatic-Module-Name header to the list of properties supported by the
osgi_java_libraryrule.Fixes #12639
Closes #14562
COPYBARA_INTEGRATE_REVIEW=#14562 from Sineaggi:add-automatic-module-name a27b3e6 PiperOrigin-RevId: 579748655