Add support for RBS, Ruby type signature#15881
Closed
qnighy wants to merge 2 commits intoprotocolbuffers:mainfrom
Closed
Add support for RBS, Ruby type signature#15881qnighy wants to merge 2 commits intoprotocolbuffers:mainfrom
qnighy wants to merge 2 commits intoprotocolbuffers:mainfrom
Conversation
Member
Contributor
|
FWIW I approve the direction of this MR 👍 looking forward to some feedback. |
|
We triage inactive PRs and issues in order to make it easier to find active work. If this PR should remain active, please add a comment. This PR is labeled |
|
We triage inactive PRs and issues in order to make it easier to find active work. If this PR should remain active or becomes active again, please reopen it. This PR was closed and archived because there has been no new activity in the 14 days since the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for RBS, a standard type signature format for Ruby. With this, Ruby programmers working on google-protobuf get better typechecking/completion/documentation experience with IDEs they are using (e.g. RubyMine and Steep).
"Support" here includes:
protocprotocfor built-in typesHere is the rationale of the all-in-one change:
But I'm willing to split the PR into smaller pieces if that's better.
This PR adds a new language
--rbs_outrather than extending the--ruby_outgenerator. This is to generate these files in a different place: we need to put the type definitions under./sig, whereas we usually put the implementation under./lib.The FFI implementation is checked by Steep to some extent, but there are a lot of suppressed errors, many of which require refactoring of the implementation. In this PR, only the trivial fixes to grammatical mistakes are applied.