Ruby implement memsize functions for native types (#10291)#15840
Merged
Ruby implement memsize functions for native types (#10291)#15840
Conversation
zhangskz
requested review from
JasonLunn and
haberman
and removed request for
a team and
JasonLunn
haberman
approved these changes
Feb 14, 2024
Fix: #10280 This allows Ruby to report a more correct estimation of the memory used by these objects. It's useful when running memory profilers against applications. cc @zhangskz @haberman Closes #10291 COPYBARA_INTEGRATE_REVIEW=#10291 from casperisfine:ruby-sizes 9150795 PiperOrigin-RevId: 606718632
zhangskz
force-pushed
the
cp-ruby-memsize
branch
from
dbe07c0 to
4902fc0
Compare
copybara-service Bot
pushed a commit
that referenced
this pull request
Jan 31, 2025
I'm not sure why, but it seems that some tests are not running via Bazel. CI uses Bazel. So I think we should add those to test correctly. Also, I fixed some tests to pass. * Run memory tests against CRuby native implementation * These tests are for CRuby native implementation. So this doesn't work with FFI and JRuby. * Ref: #15840 * Run service options extension test against CRuby native implementation * It seems that JRuby doesn't support this so far. * And, service options are frozen objects. But, in CRuby FFI, can't get a Message instance if the message is frozen. So this doesn't work. * https://github.com/protocolbuffers/protobuf/blob/d406cae0138f4f1f283a22be9474bef1f48bb0dc/ruby/lib/google/protobuf/ffi/message.rb#L419 * So the service options extension test only passes in CRuby native. Closes #19870 COPYBARA_INTEGRATE_REVIEW=#19870 from y-yagi:add_some_missing_tests d51158d PiperOrigin-RevId: 721603213
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #10280
This allows Ruby to report a more correct estimation of the memory used by these objects.
It's useful when running memory profilers against applications.
cc @zhangskz @haberman
Closes #10291
COPYBARA_INTEGRATE_REVIEW=#10291 from casperisfine:ruby-sizes 9150795 PiperOrigin-RevId: 606718632