Increased the size of the error message buffer by 4x, to 511 bytes.#15728
Merged
Increased the size of the error message buffer by 4x, to 511 bytes.#15728
Conversation
The previous limit of 127 was causing error messages to get truncated when long identifiers are in use. This will increase the stack usage of any code that is allocating a `upb_Status` on the stack. If we want to support smaller stacks in the future, we could change `upb_Status` to store its capacity inline, so different users can allocate error buffers with different capacity. Fixes: #14376 PiperOrigin-RevId: 603136385
zhangskz
requested review from
JasonLunn and
haberman
and removed request for
a team and
JasonLunn
JasonLunn
approved these changes
Feb 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous limit of 127 was causing error messages to get truncated when long identifiers are in use.
This will increase the stack usage of any code that is allocating a
upb_Statuson the stack. If we want to support smaller stacks in the future, we could changeupb_Statusto store its capacity inline, so different users can allocate error buffers with different capacity.Fixes: #14376
PiperOrigin-RevId: 603136385