Breaking Change: fixed json_encode/json_decode to use the message's pool.#15281
Closed
Breaking Change: fixed json_encode/json_decode to use the message's pool.#15281
Conversation
…ool. This bug arises only in the uncommon case where there is more than one DescriptorPool. In such a case, JSON encode/decode should always use the pool of the message being encoded/decoded, not the generated pool.
ericsalo
approved these changes
Jan 4, 2024
copybara-service Bot
pushed a commit
that referenced
this pull request
Jan 5, 2024
…ool. This bug arises only in the uncommon case where there is more than one DescriptorPool. In such a case, JSON encode/decode should always use the pool of the message being encoded/decoded, not the generated pool. Closes #15281 COPYBARA_INTEGRATE_REVIEW=#15281 from protocolbuffers:ruby-json-pool-fix 91e2dc5 FUTURE_COPYBARA_INTEGRATE_REVIEW=#15281 from protocolbuffers:ruby-json-pool-fix 91e2dc5 PiperOrigin-RevId: 595830220
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug arises only in the uncommon case where there is more than one DescriptorPool. In such a case, JSON encode/decode should always use the pool of the message being encoded/decoded, not the generated pool.