[Ruby] Fixed various weirdness with Message#to_h#15234
Merged
1 commit merged intomainfrom Jan 4, 2024
Merged
Conversation
76c92de to
1f64c17
Compare
…sly announced](https://protobuf.dev/news/2023-12-27/). Fixes: #6167 PiperOrigin-RevId: 595733611
1f64c17 to
fd69938
Compare
fd69938
philippthun
added a commit
to sap-contributions/cloud_controller_ng
that referenced
this pull request
Jun 11, 2025
The behavior of 'to_h' for Protobuf objects changed [1]; unset and default values are now being omitted. Thus the update of Protobuf libraries [2] led to an incompatible change as the Cloud Controller returned "null" instead of "0" for the external and internal ports as part of the process stats endpoint. With this change the hash is created manually by accessing all fields in the Protobuf object(s) directly. [1] protocolbuffers/protobuf#15234 [2] cloudfoundry#4359
5 tasks
philippthun
added a commit
to sap-contributions/cloud_controller_ng
that referenced
this pull request
Jun 11, 2025
The behavior of 'to_h' for Protobuf objects changed [1]; unset and default values are now being omitted. Thus the update of Protobuf libraries [2] led to an incompatible change as the Cloud Controller returned "null" instead of "0" for the external and internal ports as part of the process stats endpoint. With this change the hash is created manually by accessing all fields in the Protobuf object(s) directly. [1] protocolbuffers/protobuf#15234 [2] cloudfoundry#4359
philippthun
added a commit
to cloudfoundry/cloud_controller_ng
that referenced
this pull request
Jun 12, 2025
The behavior of 'to_h' for Protobuf objects changed [1]; unset and default values are now being omitted. Thus the update of Protobuf libraries [2] led to an incompatible change as the Cloud Controller returned "null" instead of "0" for the external and internal ports as part of the process stats endpoint. With this change the hash is created manually by accessing all fields in the Protobuf object(s) directly. [1] protocolbuffers/protobuf#15234 [2] #4359
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Ruby] Fixed various weirdness with Message#to_h
Fixes: #6167