Skip to content

[Ruby] Fixed various weirdness with Message#to_h#15234

Merged
1 commit merged intomainfrom
test_594323584
Jan 4, 2024
Merged

[Ruby] Fixed various weirdness with Message#to_h#15234
1 commit merged intomainfrom
test_594323584

Conversation

@copybara-service
Copy link
Copy Markdown

[Ruby] Fixed various weirdness with Message#to_h

Fixes: #6167

@copybara-service copybara-service Bot force-pushed the test_594323584 branch 10 times, most recently from 76c92de to 1f64c17 Compare January 3, 2024 23:42
@copybara-service copybara-service Bot closed this pull request by merging all changes into main in fd69938 Jan 4, 2024
@copybara-service copybara-service Bot deleted the test_594323584 branch January 4, 2024 18:02
philippthun added a commit to sap-contributions/cloud_controller_ng that referenced this pull request Jun 11, 2025
The behavior of 'to_h' for Protobuf objects changed [1]; unset and
default values are now being omitted. Thus the update of Protobuf
libraries [2] led to an incompatible change as the Cloud Controller
returned "null" instead of "0" for the external and internal ports as
part of the process stats endpoint.

With this change the hash is created manually by accessing all fields in
the Protobuf object(s) directly.

[1] protocolbuffers/protobuf#15234
[2] cloudfoundry#4359
philippthun added a commit to sap-contributions/cloud_controller_ng that referenced this pull request Jun 11, 2025
The behavior of 'to_h' for Protobuf objects changed [1]; unset and
default values are now being omitted. Thus the update of Protobuf
libraries [2] led to an incompatible change as the Cloud Controller
returned "null" instead of "0" for the external and internal ports as
part of the process stats endpoint.

With this change the hash is created manually by accessing all fields in
the Protobuf object(s) directly.

[1] protocolbuffers/protobuf#15234
[2] cloudfoundry#4359
philippthun added a commit to cloudfoundry/cloud_controller_ng that referenced this pull request Jun 12, 2025
The behavior of 'to_h' for Protobuf objects changed [1]; unset and
default values are now being omitted. Thus the update of Protobuf
libraries [2] led to an incompatible change as the Cloud Controller
returned "null" instead of "0" for the external and internal ports as
part of the process stats endpoint.

With this change the hash is created manually by accessing all fields in
the Protobuf object(s) directly.

[1] protocolbuffers/protobuf#15234
[2] #4359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Ruby] Message hashes including non-oneof values

1 participant