Add Automatic-Module-Name#14562
Closed
Sineaggi wants to merge 3 commits intoprotocolbuffers:mainfrom
Closed
Conversation
Sineaggi
requested review from
acozzette and
shaod2
and removed request for
a team
deannagarcia
added
the
🅰️ safe for tests
github-actions
Bot
removed
the
🅰️ safe for tests
deannagarcia
approved these changes
Nov 1, 2023
deannagarcia
added
java
kotlin
🅰️ safe for tests
github-actions
Bot
removed
the
🅰️ safe for tests
Author
|
https://github.com/protocolbuffers/protobuf/actions/runs/6724762122/job/18277738222?pr=14562 one check failed, unrelated to my changes. |
Member
|
Agreed this failure is unrelated, a team member is working on getting it fixed. |
deannagarcia
added
the
🅰️ safe for tests
github-actions
Bot
removed
the
🅰️ safe for tests
deannagarcia
added
the
🅰️ safe for tests
github-actions
Bot
removed
the
🅰️ safe for tests
4 tasks
zhangskz
pushed a commit
that referenced
this pull request
Apr 2, 2024
Adds Automatic-Module-Name after it was lost during the maven-bazel migration (and subsequent re-addition of osgi bundle support). Updates OsgiWrapper to support adding the Automatic-Module-Name header to the list of properties supported by the `osgi_java_library` rule. Fixes #12639 Closes #14562 COPYBARA_INTEGRATE_REVIEW=#14562 from Sineaggi:add-automatic-module-name a27b3e6 PiperOrigin-RevId: 579748655
Closed
zhangskz
added a commit
that referenced
this pull request
Apr 5, 2024
Cherry-Pick Add Automatic-Module-Name (#14562)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Automatic-Module-Name after it was lost during the maven-bazel migration (and subsequent re-addition of osgi bundle support).
Updates OsgiWrapper to support adding the Automatic-Module-Name header to the list of properties supported by the
osgi_java_libraryrule.Fixes #12639