[23.x] Backport deps: Update Guava 32.0.1#13106
Merged
zhangskz merged 1 commit intoprotocolbuffers:23.xfrom Jun 20, 2023
chadlwilson:backport-bump-guava-3201
Merged
[23.x] Backport deps: Update Guava 32.0.1#13106zhangskz merged 1 commit intoprotocolbuffers:23.xfrom chadlwilson:backport-bump-guava-3201
zhangskz merged 1 commit intoprotocolbuffers:23.xfrom
chadlwilson:backport-bump-guava-3201
Conversation
Follow-up from #12953 to update to `32.0.1` to fix an issue on windows: https://github.com/google/guava/releases/tag/v32.0.1 The underlying issue likely does not affect protobuf as it does not appear to (directly) use the affected `Files.createTempDir` or `FileBackedOutputStream` code which was apparently broken on Windows in `32.0.0`. Seems best to update anyway. (cherry picked from commit c95ebb7)
mkruskal-google
added
the
🅰️ safe for tests
mkruskal-google
approved these changes
Jun 20, 2023
github-actions
Bot
removed
the
🅰️ safe for tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #13099
Follow-up from #13002 to update to
32.0.1to fix an issue on windows:https://github.com/google/guava/releases/tag/v32.0.1
The underlying issue likely does not affect protobuf as it does not appear to (directly) use the affected
Files.createTempDirorFileBackedOutputStreamcode which was apparently broken on Windows in32.0.0.Seems best to update anyway.