Skip to content

Add dllexport_decl for generated default instance.#13085

Closed
owent wants to merge 1 commit intoprotocolbuffers:mainfrom
owent:add_dllexport_decl_for_generated_default_instance
Closed

Add dllexport_decl for generated default instance.#13085
owent wants to merge 1 commit intoprotocolbuffers:mainfrom
owent:add_dllexport_decl_for_generated_default_instance

Conversation

@owent
Copy link
Copy Markdown
Contributor

@owent owent commented Jun 16, 2023

Fixes #13084

@owent owent requested a review from a team as a code owner June 16, 2023 13:26
@owent owent requested review from sbenzaquen and removed request for a team June 16, 2023 13:26
@fowles fowles added c++ 🅰️ safe for tests Mark a commit as safe to run presubmits over and removed 🅰️ safe for tests Mark a commit as safe to run presubmits over labels Jun 16, 2023
fowles added a commit that referenced this pull request Jun 16, 2023
Add dllexport_decl for generated default instance. (#13085)
@fowles
Copy link
Copy Markdown
Contributor

fowles commented Jun 16, 2023

Cheery picked back to 23.x so this will be in the next point release which is pending on #13075

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🅰️ safe for tests Mark a commit as safe to run presubmits over c++

Projects

None yet

Development

Successfully merging this pull request may close these issues.

$dllexport_decl$ is missing in generated .pb.cc

2 participants