Modify port_def.inc to ignore -Wshadow warning#13059
Closed
4kangjc wants to merge 1 commit intoprotocolbuffers:mainfrom
Closed
Modify port_def.inc to ignore -Wshadow warning#130594kangjc wants to merge 1 commit intoprotocolbuffers:mainfrom
4kangjc wants to merge 1 commit intoprotocolbuffers:mainfrom
Conversation
fowles
approved these changes
Jun 14, 2023
Contributor
|
there was a thing in our tree that held up our automation. Do you mind rebasing to latest? |
fowles
added
cleanup
and removed
🅰️ safe for tests
fowles
approved these changes
Jun 14, 2023
Contributor
Author
OK. |
fowles
approved these changes
Jun 15, 2023
fowles
added
🅰️ safe for tests
Contributor
Author
|
@fowles Is there anything else that needs to be changed? |
Contributor
|
no, we need to kick a few things on our side |
fowles
added a commit
that referenced
this pull request
Jun 16, 2023
Modify port_def.inc to ignore -Wshadow warning (#13059)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13037