fix: avoid warnings with MSVC (#12762)#12775
Merged
fowles merged 1 commit intoprotocolbuffers:23.xfrom May 12, 2023
fowles:23.x
Merged
fix: avoid warnings with MSVC (#12762)#12775fowles merged 1 commit intoprotocolbuffers:23.xfrom fowles:23.x
fowles merged 1 commit intoprotocolbuffers:23.xfrom
fowles:23.x
Conversation
In both cases a `size_t` was being converted to a `uint32_t`. These headers are used from application code, or at least from generated code, and the application may be compiling with more warnings enabled than normal. Closes #12762 COPYBARA_INTEGRATE_REVIEW=#12762 from coryan:fix-avoid-warnings-with-MSVC 5ba6b5d PiperOrigin-RevId: 531506224
fowles
added
🅰️ safe for tests
fowles
added
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
sbenzaquen
approved these changes
May 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In both cases a
size_twas being converted to auint32_t. These headers are used from application code, or at least from generated code, and the application may be compiling with more warnings enabled than normal.Closes #12762
COPYBARA_INTEGRATE_REVIEW=#12762 from coryan:fix-avoid-warnings-with-MSVC 5ba6b5d PiperOrigin-RevId: 531506224