fix: avoid warnings with MSVC#12762
Closed
coryan wants to merge 2 commits intoprotocolbuffers:mainfrom
coryan:fix-avoid-warnings-with-MSVC
Closed
fix: avoid warnings with MSVC#12762coryan wants to merge 2 commits intoprotocolbuffers:mainfrom coryan:fix-avoid-warnings-with-MSVC
coryan wants to merge 2 commits intoprotocolbuffers:mainfrom
coryan:fix-avoid-warnings-with-MSVC
Conversation
In both cases a `size_t` was being converted to a `uint32_t`. These headers are used from application code, or at least from generated code, and the application may be compiling with more warnings enabled than normal.
fowles
reviewed
May 11, 2023
src/google/protobuf/string_block.h
Outdated
| @@ -145,7 +145,8 @@ inline StringBlock* StringBlock::Emplace(void* p, size_t n, StringBlock* next) { | |||
| ABSL_DCHECK_EQ(n, NextSize(next)); | |||
| uint32_t doubled = static_cast<uint32_t>(n) * 2; | |||
Contributor
There was a problem hiding this comment.
rather than having the static_cast twice in this function, can you pull a local?
Contributor
Author
There was a problem hiding this comment.
I missed that, done. Do you still want the doubled temporary?
github-actions
bot
removed
the
🅰️ safe for tests
fowles
approved these changes
May 11, 2023
github-actions
bot
removed
the
🅰️ safe for tests
fowles
added a commit
that referenced
this pull request
May 12, 2023
fix: avoid warnings with MSVC (#12762)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In both cases a
size_twas being converted to auint32_t. These headers are used from application code, or at least from generated code, and the application may be compiling with more warnings enabled than normal.