Fix CommonJS relative require generation, and test it#1274
Merged
haberman merged 2 commits intoprotocolbuffers:masterfrom Feb 29, 2016
Merged
Fix CommonJS relative require generation, and test it#1274haberman merged 2 commits intoprotocolbuffers:masterfrom
haberman merged 2 commits intoprotocolbuffers:masterfrom
Conversation
js/test6/test6.proto
Outdated
|
|
||
| message ImportedMessage { | ||
| string string_value = 1; | ||
| } No newline at end of file |
Contributor
Author
|
All comments done. |
Contributor
Author
|
ping |
haberman
added a commit
that referenced
this pull request
Feb 29, 2016
Fix CommonJS relative require generation, and test it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes proto files that require each other use the proper relative CommonJS require statements. It also adds a simple test with two proto files in different directories, with one importing the other.