fix: avoid warnings on Windows#12701
Closed
coryan wants to merge 1 commit intoprotocolbuffers:mainfrom
coryan:fix-warnings-repeated-field-warnings-in-msvc
Closed
fix: avoid warnings on Windows#12701coryan wants to merge 1 commit intoprotocolbuffers:mainfrom coryan:fix-warnings-repeated-field-warnings-in-msvc
coryan wants to merge 1 commit intoprotocolbuffers:mainfrom
coryan:fix-warnings-repeated-field-warnings-in-msvc
Conversation
On Wndows, `size_t` is 64-bits, and `int` is 32-bits. That makes conversions from `size_t` to `int` potentially lossy, and they generate warnings. In this case an `int` variable was assigned to `size_t` and then passed to functions consuming `int`. Seems simpler to use `auto` and avoid these problems altogether.
fowles
approved these changes
May 7, 2023
github-actions
bot
removed
the
🅰️ safe for tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Wndows,
size_tis 64-bits, andintis 32-bits. That makes conversions fromsize_ttointpotentially lossy, and they generate warnings. In this case anintvariable was assigned tosize_tand then passed to functions consumingint. Seems simpler to useautoand avoid these problems altogether.