Skip to content

Cherrypick cmake fixes to 22.x#12668

Merged
mkruskal-google merged 6 commits into22.xfrom
cmake-fixes-22
May 4, 2023
Merged

Cherrypick cmake fixes to 22.x#12668
mkruskal-google merged 6 commits into22.xfrom
cmake-fixes-22

Conversation

@mkruskal-google
Copy link
Copy Markdown
Member

No description provided.

mkruskal-google and others added 4 commits May 4, 2023 12:21
* Bump Abseil submodule to 20230125.3

* Fix gtest installation setup with submodules
PiperOrigin-RevId: 529429609
This partially addresses #12201

Closes #12660

COPYBARA_INTEGRATE_REVIEW=#12660 from mkruskal-google:absl-update ce07c45
PiperOrigin-RevId: 529456996
These more closely follow the standard practices of our users, where dependencies are pre-installed instead of using our provided sub-modules.  This will prevent issues such as #12201 from reoccuring.

Additionally, this cl bumps our Abseil dependency to the latest release, and fixes a GTest issue that went previously unnoticed.

PiperOrigin-RevId: 529490402
@mkruskal-google mkruskal-google added the back-port Cherrypick PRs to release branches label May 4, 2023
This should fix #12374, #12375, and #12450. The `protobuf_PROTOC_EXEC` variable
is not defined, and I think `protobuf::protoc` is what we should be using
instead.

PiperOrigin-RevId: 525591320
@mkruskal-google mkruskal-google merged commit dbb9f9b into 22.x May 4, 2023
@mkruskal-google mkruskal-google deleted the cmake-fixes-22 branch May 4, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

back-port Cherrypick PRs to release branches

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants