Added support for CommonJS require()#1215
Merged
haberman merged 13 commits intoprotocolbuffers:masterfrom Feb 19, 2016
Merged
Conversation
There was a problem hiding this comment.
A link to the protoc downloads would be nice.
Member
Author
|
I added a commit to address your comments. PTAL. |
There was a problem hiding this comment.
In general, your JS is a big mix of camel case and underscore naming. Be consistent if you can.
Member
Author
There was a problem hiding this comment.
Done. Good catch on that -- I don't write enough JavaScript regularly to be used to camelCasing. :)
"nodejs" does not exist on Travis, it appears.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This required several codegen changes and a bunch of glue in gulp.js to test it all.