Add static asserts to container classes.#11550
Closed
copybara-service[bot] wants to merge 0 commit intomainfrom
Closed
Add static asserts to container classes.#11550copybara-service[bot] wants to merge 0 commit intomainfrom
copybara-service[bot] wants to merge 0 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_496676724
branch
from
6dc2b24 to
72c8a09
Compare
copybara-service
bot
force-pushed
the
test_496676724
branch
from
72c8a09 to
5a8abe1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add static asserts to container classes.
This will prevent unsupported uses of these classes downstream, which can behave surprisingly and increase the friction of changes to protobuf. Specifically RepeatedField, RepeatedPtrField, and Map will only be allowed to hold the types listed in https://protobuf.dev/programming-guides/proto. The old behavior allowed them to hold just about anything, including custom user types.